-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up -Wextra warnings #80
Comments
A good number of these are -Wunused-parameter warnings in lparstat. In particular it looks like most of the get data accessors don't use the As an example:
A couple options if we care enough to get rid of these warnings is |
The errinjct source has a similar scenario with an array of elements that contain function pointers. In particular for each possible errinjct function there is a function pointer to validate additional command line arguments. Three of these always return error as they don't expect additional arguments and thusly don't parse the input parameters which are being correctly reported as unused. This scenario is easily fixed by just setting these function pointers to NULL, and allowing the argument parsing loop in |
The remaining warnings are all |
Enabling -Wextra in the build generates a fair number of warning worth cleaning up.
The text was updated successfully, but these errors were encountered: