Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add a pallet test for estimate_fee that skip validation #1575

Closed
tdelabro opened this issue Apr 26, 2024 · 4 comments
Closed

dev: Add a pallet test for estimate_fee that skip validation #1575

tdelabro opened this issue Apr 26, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@tdelabro
Copy link
Collaborator

It is now possible to skip the validation phase during estimate_fee. Write a check that uses it to validate an otherwise invalid tx.
Do it in crates/pallets/starknet/src/tests/query_tx.rs
Replace the usual Default::default() parameter by an use of the flag

@tdelabro tdelabro added the enhancement New feature or request label Apr 26, 2024
@stevencartavia
Copy link
Contributor

Hi, can I take this?

@tdelabro
Copy link
Collaborator Author

susre @stevencartavia

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label May 30, 2024
@tdelabro
Copy link
Collaborator Author

solved by #1584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants