You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While investigating an issue with Volume Shadow Copy, I noticed that Kopia was still scanning/reading from the original directory even when I specified to use a filesystem snapshot (VSS). I thought this was odd so I looked into it, it seems the culprit is here:
A go routine for scanDirectory is started before uploadDirWithCheckpointing, and the processing of filesystem snapshotting and directory overrides is only done in uploadDirWithCheckpointing.
This means the upload estimates when using folder overrides (including filesystem snapshots) will be incorrect.
I'm not very familiar with the codebase, so it may not be this simple, but it seems like this might be able to be fixed by simply moving the folder override and filesystem snapshot handling that is in uploadDirWithCheckpointing to before the filesize estimate go routine, and then pass the resulting fs.Directory to both the EstimatedDataSize and uploadDirWithCheckpointing functions.
The text was updated successfully, but these errors were encountered:
While investigating an issue with Volume Shadow Copy, I noticed that Kopia was still scanning/reading from the original directory even when I specified to use a filesystem snapshot (VSS). I thought this was odd so I looked into it, it seems the culprit is here:
kopia/snapshot/snapshotfs/upload.go
Lines 1289 to 1301 in 2b92388
A go routine for
scanDirectory
is started beforeuploadDirWithCheckpointing
, and the processing of filesystem snapshotting and directory overrides is only done inuploadDirWithCheckpointing
.kopia/snapshot/snapshotfs/upload.go
Lines 594 to 597 in 2b92388
kopia/snapshot/snapshotfs/upload.go
Line 610 in 2b92388
This means the upload estimates when using folder overrides (including filesystem snapshots) will be incorrect.
I'm not very familiar with the codebase, so it may not be this simple, but it seems like this might be able to be fixed by simply moving the folder override and filesystem snapshot handling that is in
uploadDirWithCheckpointing
to before the filesize estimate go routine, and then pass the resultingfs.Directory
to both theEstimatedDataSize
anduploadDirWithCheckpointing
functions.The text was updated successfully, but these errors were encountered: