New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential bug: Fix not to allow different types for template parameters #210

Open

TomTaehoonKim opened this issue Dec 21, 2023 · 0 comments

Labels

bug

Contributor

TomTaehoonKim commented Dec 21, 2023

IMO, as what I've suggested in this comment, #206 (comment).

template <typename Domain, typename Poly,
          typename Evals = typename Domain::Evals, typename F>
Evals CoeffToExtendedPart(const Domain* domain, const Poly& poly, const F& zeta,

this kind of code would be more correct to be written as below.

template <typename Domain>
typename Domain::Evals CoeffToExtendedPart(const Domain* domain, const typename Domain::Poly& poly, const typename Domain::Field& zeta,

TomTaehoonKim added the bug label

TomTaehoonKim mentioned this issue

feat(zk): implement combined custom gate column builder #206

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment