Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Cpplint in CI checks moved files lint #271

Open
Insun35 opened this issue Feb 1, 2024 · 0 comments
Open

Ensure Cpplint in CI checks moved files lint #271

Insun35 opened this issue Feb 1, 2024 · 0 comments

Comments

@Insun35
Copy link
Contributor

Insun35 commented Feb 1, 2024

Current behavior?

In our CI process, Cpplint is set up to check files that have been modified as identified by git diff.
However, CI skips files that have been moved, because it can not open and read them.

For instance, in commit 5023e99, the paths of permutation_argument_stringifer.h and permutation_verifying_key_stringifier.h were changed. This change led to an oversight of a header guard typo, as the CI process skipped these files.

Expected Behavior?

Due to the extensive size of our codebase, running Cpplint on the entire code is not efficient. Therefore, we aim to check only the modified files. However, the process needs enhancement to ensure that files with changed paths (moved files) are not skipped and are thoroughly checked.

Standalone code or description to reproduce the issue

  1. Introduce an intentional error recognizable by Cpplint, such as an inappropriate header guard, in a file.
  2. Move the file to a different directory.
  3. Run the CI process and observe if Cpplint checks the moved file.

Further details can be found in commit 5023e99 and its CI Log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant