refac: change function signature T Inverse() to bool Inverse(T*)
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you try building? If you try building, you face a lot of compile error because you changed the function signature. What you should do after changing signature is tol resolve compiler error |
|
@saliaku Please check the CI log. It must pass Lint, Build, and Test. |
chokobole
changed the title
T Inverse() to bool Inverse(T*)
chokobole
changed the title
T Inverse() to bool Inverse(T*)T Inverse() to bool Inverse(T*)
|
@saliaku I'll close the issue if you want to keep working on this, please reopen the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added .vscode to the .gitignore file so that people who uses vs code for development can make use of it
The changes that were asked to be made were made. I am right now using Debian so I am unable to test the software.
would be happy to help in any way possible though
Fixes #76