Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling invalid proofs #9

Open
lorenzb opened this issue Jul 30, 2018 · 2 comments
Open

Handling invalid proofs #9

lorenzb opened this issue Jul 30, 2018 · 2 comments
Milestone

Comments

@lorenzb
Copy link
Owner

lorenzb commented Jul 30, 2018

On receiving an invalid proof, theProvethVerifier contract currently:

  • either reverts
  • or doesn't revert and notifies the caller that the proof wasn't valid.

It should be either one or the other.

@relyt29
Copy link
Collaborator

relyt29 commented Aug 13, 2018

Well, according to the solidity documentation,

"Catching exceptions is not yet possible."

so maybe that influences this decision, personally I think reverting is saner, but if the EVM doesn't support catching exceptions then that leaves a developer with no real way of doing anything other than bubbling up and reverting as well, if a MPP fails

@lorenzb lorenzb added this to the beta milestone Aug 16, 2018
@lorenzb
Copy link
Owner Author

lorenzb commented Aug 24, 2018

Agreed, let's revert.

We could handle exceptions with a low-level solidity "exception handler" that catches reverts and returns invalid instead.

@lorenzb lorenzb mentioned this issue Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants