Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--max-electrum-connections param is invalid #111

Open
brain-zhang opened this issue Mar 25, 2021 · 1 comment
Open

--max-electrum-connections param is invalid #111

brain-zhang opened this issue Mar 25, 2021 · 1 comment
Assignees
@gdassori
Labels
bug Something isn't working

Comments

@brain-zhang
Copy link

run spruned by [--max-electrum-connections MAX_ELECTRUM_CONNECTIONS] params seems invalid;

Maybe:

https://github.com/gdassori/spruned/blob/12df1211477c569560df0a2f4160bf9d1d8afe6f/spruned/daemon/electrod/__init__.py#L55

Should Be:
connections=ctx.max_electrum_connections,

Because we set max_electrum_connections at beginning here:

https://github.com/gdassori/spruned/blob/12df1211477c569560df0a2f4160bf9d1d8afe6f/spruned/application/context.py#L82-L87
@gdassori gdassori self-assigned this May 13, 2021
@gdassori gdassori added the bug Something isn't working label May 13, 2021
gdassori added a commit that referenced this issue May 17, 2021
@gdassori
removed unused try\except, fixed #111
b05d181
@gdassori
Copy link
Member

Thanks for reporting, the fix is ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdassori gdassori

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brain-zhang @gdassori