Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] Improve layout on mobile #61

Open
1 of 2 tasks
juharris opened this issue Dec 9, 2019 · 8 comments
Open
1 of 2 tasks

[demo] Improve layout on mobile #61

juharris opened this issue Dec 9, 2019 · 8 comments
Assignees
Labels
demo Relates to the code to demonstrate the framework enhancement New feature or request good first issue Good for newcomers Priority: Low

Comments

@juharris
Copy link
Member

juharris commented Dec 9, 2019

  • Footer background does not stretch
  • Tables (refund, reward, deployment info) are not visible
@juharris juharris added enhancement New feature or request good first issue Good for newcomers demo Relates to the code to demonstrate the framework labels Dec 9, 2019
@hkaur008
Copy link
Contributor

Hi @juharris
Are you asking for responsiveness over mobile?
I think this is frontend work , could you direct me to the file and changes I have to do?

@juharris
Copy link
Member Author

Responsiveness is good. There might also be issues with tables in model.js being too wide to display.

@hkaur008
Copy link
Contributor

hkaur008 commented Apr 26, 2021

Can you attach screenshot of present layout on mobile and what exactly you want as a layout change . I would try to improve that.
Do I just have to run client side set up ? Can you direct me a little bit .
https://github.com/microsoft/0xDeCA10B/tree/main/demo/client

@juharris
Copy link
Member Author

I could send a picture but you'll have to run the demo/client to see how your change will look in any case. You can tell you browser to display a page how it would display on a mobile device. Usually you can open the DevTools (F12) and then click on the phone/tablet icon around the top left. Setup instructions: https://github.com/microsoft/0xDeCA10B/tree/main/demo#setup

@hkaur008
Copy link
Contributor

I could send a picture but you'll have to run the demo/client to see how your change will look in any case. You can tell you browser to display a page how it would display on a mobile device. Usually you can open the DevTools (F12) and then click on the phone/tablet icon around the top left. Setup instructions: https://github.com/microsoft/0xDeCA10B/tree/main/demo#setup

please assign me this issue as well ! will keep you updated over this

@hkaur008
Copy link
Contributor

hkaur008 commented Jun 2, 2021

Hey! , actually i wanted ti work over this do let me now when to start !

@ritik307
Copy link

ritik307 commented Feb 5, 2022

@juharris I am interested in solving this issue. But I am currently facing an issue while setting up the project on my local machine. I followed the REEADME.md file but still faced trouble while running the project. Following are the commands I ran in order to set up the project.

  • yarn install
    ss1

  • sudo apt install build-essential
    ss1

  • ./setup.sh

  • yarn start
    Screenshot from 2022-02-05 15-57-58

Kindly help me out ☹️

@juharris
Copy link
Member Author

juharris commented Feb 5, 2022

Thanks for your interest in the project. The steps in README.md are correct. Please run them in the order shown from the demo folder (because that's the folder with README.md) and make sure each one is successful before moving on to the next.
The error from yarn install isn't shown but I believe the troubleshooting steps in README.md will help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demo Relates to the code to demonstrate the framework enhancement New feature or request good first issue Good for newcomers Priority: Low
Projects
None yet
Development

No branches or pull requests

3 participants