-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mirage 4.5.0 errors report sometimes off-by-one #1528
Comments
AFAICT all |
samoht
added a commit
to samoht/mirage
that referenced
this issue
May 17, 2024
hannesm
pushed a commit
to samoht/mirage
that referenced
this issue
May 17, 2024
hannesm
added a commit
that referenced
this issue
May 17, 2024
* internal: Fix off-by-one locations in mirage/main.ml Fix #1528 * Promote tests * fix, use 2 offset, add comment * promote tests --------- Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
hannesm
added a commit
to hannesm/opam-repository
that referenced
this issue
May 17, 2024
CHANGES: - BREAKING: remove `~name` parameter from Mirage.Runtime_args.create (mirage/mirage#1541 @samoht, fixes mirage/mirage#1532) - BREAKING: remove `~name` parameter from Mirage.runtime_arg, and use a string (instead of a format string) as third parameter (mirage/mirage#1541 @samoht) - constrain the `start` function to `unit Lwt.t`. Previously, there was no restrictions, and lots of time was spent in debugging when a unikernel resulted in `unit Lwt.t Lwt.t` (@Julow mirage/mirage#1524) - revise man page sections and ordering: ARGUMENTS, OPTIONAL, NETWORK OPTIONS, DISK OPTIONS, LOG AND MONITORING OPTIONS, OCAML RUNTIME OPTIONS. Previously, the ARGUMENTS and OPTIONS were put later, and were hard to find. These are the sections where unikernel-specific arguments are put by default (mirage/mirage#1531 @hannesm @reynir) - add --net=host and --net=ocaml to reduce confusion. --net=host uses the TCP/IP socket stack, --net=ocaml the OCaml network stack (mirage/mirage#1525 @hannesm) - quote Runtime_arg.call (mirage/mirage#1522 @Julow) - documentation fixes (inline examples @Julow mirage/mirage#1523, @hannesm mirage/mirage#1537 (fixes mirage/mirage#1512 reported by @reynir), Runtime_args.create mirage/mirage#1541 @samoht) - fix the build instructions of the generated opam file: since 4.5.0 `mirage build` is no longer available, use `make "build"` (mirage/mirage#1527 @hannesm) - add RELEASE.md, a guide on how to cut a mirage release (mirage/mirage#1519 @samoht) - allow git 3.16 (mirage/mirage#1536 @hannesm) - use mirage-bootvar (using dune variant) instead of parse-argv and mirage-bootvar-xen, mirage-bootvar-solo5, mirage-bootvar-unix (mirage/mirage#1533 @hannesm) - BUGFIX: reset the lexer location before applying functors in generated code (mirage/mirage#1539 @samoht, fixes mirage/mirage#1520 @hannesm) - BUGFIX: fix off-by-one locations for mirage/main.ml (mirage/mirage#1540 @samoht, fixes mirage/mirage#1528 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey,
so I have the following generated file -- :
Emacs agrees with the line number: the directive
# 171
is on line 171, the directive# 191
on line 191.When I run a make build, I get:
But the use of
>>|=
is in line 187, characters 24-28. How can that be?If you need a full example, the above is from mirage-skeleton/tutorial/hello with a mirage configure -t hvt and then a manual edit of the file (to inject bad syntax).
The text was updated successfully, but these errors were encountered: