Cohttp-lwt, Server: How should we now close `Expert response_action?

[pirbo]

Type Cohttp.S.IO.ic is now abstract and (as far as I can see) there is no function provided to "close" one. Therefore either

ocaml-cohttp/cohttp-lwt/src/s.ml

Lines 293 to 294 in de39002

	{!unit Lwt.t} is resolved. The connection can be closed by closing the
	{!IO.ic}. *)

is not anymore the way to go and the comment needs an update or we need a way to do the recommended action :-)

Note that in any case, this introduce a breaking change as existing code using cohttp.5 has some Lwt_io.close ic that doesn't type anymore. (Discovered by testing the compatibility of https://gitlab.com/nomadic-labs/resto with cohttp.6)

[mseri]

I would go with your second suggestion, do you have a suggestion on how to re-introduce it?

[mseri]

In cohttp-lwt-unix the Input_channel has a close function, perhaps we could make that a requirement from the signature?