You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The memory barriers are in the xenctrl module at the moment which
seems the wrong place. Additionally, x86 is strongly ordered, so
comment them out for now until we can get the mb operations into a
library elsewhere.
If this library only works reliably on x86, we should probably document that somewhere.
The text was updated successfully, but these errors were encountered:
Yes indeed. This strongly suggests that the library should be x86_64 only. It would be a nicer fix to dig out the right memory barriers from upstream vchan implementations and put the right ones in this library.
All the memory barriers in the vchan source have been commented out. e.g.
ocaml-vchan/lib/endpoint.ml
Line 245 in 8d2b940
The log message (0375089) from 2014 says:
If this library only works reliably on x86, we should probably document that somewhere.
The text was updated successfully, but these errors were encountered: