Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnection should return redirect links instead of redirect the whole page. #1010

Open
DevSlashRichie opened this issue Oct 6, 2022 · 1 comment

Comments

@DevSlashRichie
Copy link

Is your feature request related to a problem? Please describe.
I want to be able to use the link in an iframe or popup instead of redirecting the complete webapp.

Describe the solution you'd like
Allowing WalletConnection to have methods that return the redirect URI instead of ultimately returning the web page.

Describe alternatives you've considered
Embedding the whole near-api-js connect into its own code space and running that into a popup.

Additional context

window.location.assign(newUrl.toString());

@denbite
Copy link
Contributor

denbite commented Jan 14, 2024

the idea of having methods for generating a Wallet URL without redirecting looks also reasonable to me and was implemented in #1260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog 🥶
Development

No branches or pull requests

2 participants