Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore dist #72

Open
stripedpajamas opened this issue Jan 15, 2020 · 0 comments
Open

Ignore dist #72

stripedpajamas opened this issue Jan 15, 2020 · 0 comments

Comments

@stripedpajamas
Copy link
Contributor

I recommend git-ignoring the dist folder. The files can be generated on first run or with the npm postinstall script. As it is, code reviews are noisy (babel and minified code shows up) and there's a bit of a security risk in that one could sneak code into the dist files and most reviewers would not notice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stripedpajamas