-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar invites: Administrator shall choose if server's or user's email adress is used #5080
Comments
@tuergeist This is the place to go: Feel free to send a PR that implements this optionally. :) |
(Message provides a |
Hi @georgehrke, IMHO the problem is the sender's address which I cannot change easily in neither code locations you pointed to. [Or I'm just too stupid] |
Aaahh. Got it. |
Any news on this? |
I'd add that this is an important issue for us at MayFirst.org, who use the same NextCloud across a great many domains and organizational identities. We really need these invitation emails to be coming from the users who send them. Thanks to all who have the capacity and willingness to work on this. |
@georgehrke 🎺 could you update this? :) |
cc @jancborchardt This is what we talked about on Talk. |
to summarise the problem:
... and our options:
|
Sounds like a good idea in general. |
Sounds good and seems we should do both options? Everyone who commented in the thread: Would this solve your issue? |
I'm no dev, but you can get this done by editing nextcloudroot/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php Change line 255 from: And your invites will come from the email address of the user instead of the server. |
@gitterdoneplease this is a bit weird. I'm sure some mail servers will either not allow you to send a message with a mismatching |
If all users use the same email domain, why should it be blocked? |
This is something we can't assume. See my comment above: |
Dunno gents. I run the mail server too so it’s not an issue for me. A big warning in the GUI should be enough, but this was necessary in my case to transition completely to NC. Spoofing a from header if you AUTH on a SMTP server is painless, but as pointed out may trigger spam/junk detectors. |
This comment has been minimized.
This comment has been minimized.
I am aware about quite a few organisations with different email domains. This easily happens with mergers, different legal entities for parts of a company (e.g. regulated business vs. un-regulated business, ...). There are tons of situations where this can happen. Just don't assume that this is always fixed. Adding flexibility does not hurt at all and eases the work of the admins. |
I also want to add that even if the mail server / domain is the same, the mail server will not necessarily allow you to send as some.user@my.tld with the credentials for the nextcloud notification mail (often something like nextcloud@my.tld). Also, since normal non-admin users can usually add and change mail settings via the nextcloud mail app, whether overriding the From header with the notification mail server and credentials will work can even change easily just through a settings change by an unprivileged user! So I would suggest:
and send out calendar invitations from the user mail address (using the user mail credentials!) only if both settings are enabled. |
@ChristophWurst Has there been any progress on this? In my case, it seems that the emails sent by the server itself have a higher chance of ending in spam than the users' email addresses sending. |
I've been modifying the code for all of the versions since my first post to make this work. Would be great to have individual email addresses send calendar invites the way other systems work. |
I also have a requirement and would be happy to help with this. At least a mail server with two domains. More could be added. Postfix + Dovecot + MySQL + Spamasassin + ClamAV. Also need synchronizations and sending invitations to calendars on smartphones. |
Hi all, with SPF and DKIM records set correctly this really all works painlessly now except for manually changing the code. Could we please get something in the UI? It would be really great. Thanks so much. |
Is there some guide that you followed? |
How to set DNS records correctly? There is a lot of help out there, but I’d look at MxToolBox. |
Every new version I come back here to find what needs to be changed again. It's still in nextcloudroot/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php, but now the line number is 244. Change line 244 from: |
Hi all, And perhaps another small issue no-one seems to have noticed. At least not yet. When you send the appointment, it does not show up in the sent items mail folder. Neither in my user account's mailbox, nor in the admin account's mailbox (after I modified the setting as described in the comment above). Which can be a nuisance. Consider this scenario: These "features" should not even be considered feature requests. They should simply be matching all the other similar solutions on the market. Out of the box. LE, after performing some additional tests: Currently tested on Nextcloud 25.0.12. My suggestion would be that if the currently logged in user has one or more e-mail account(s) configured in the "Mail" client interface, nextcloud should by default use the account configured as default in the mail client. |
I think that'd deserve its own, dedicated issue. That'd probably more considered a bug than an enhancement/feature request. |
Feature Request
I refer to #2345 and #2778.
If a Nextcloud instance serves for users from different domains (which is the case at least for me), it's annoying that calendar invites are sent with the server's email address instead of the user's once. For me it would be fine if the server's address is taken if there is no user email configured.
To avoid problems with mailservers that might not accept sending emails for more than one domain, this behavior this could be made optional.
(In my case all domains are hosted and handled by one email server and one nextcloud server - I would not like to set up a nextcloud instance per domain).
(If someone is so nice and point me to the place where I can change it in the code myself, would be fine too)
Implementation
Delegate sending emails to apps. The main target is the Mail app but others may offer this integration too.
Work packages
The text was updated successfully, but these errors were encountered: