Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not put contract script into wallet.Account script #3348

Closed
AnnaShaleva opened this issue Mar 11, 2024 · 0 comments · Fixed by #3470
Closed

Do not put contract script into wallet.Account script #3348

AnnaShaleva opened this issue Mar 11, 2024 · 0 comments · Fixed by #3470
Assignees
@AliceInHunterland
Labels
bug Something isn't working I4 No visible changes S3 Minimally significant U3 Regular wallet NEP-6 wallet and accounts
Milestone
v0.106.2

Comments

@AnnaShaleva
Copy link
Member

Ref. #3332 (comment). It should be fixed in both tests and code.
@AnnaShaleva AnnaShaleva added bug Something isn't working wallet NEP-6 wallet and accounts I3 Minimal impact U3 Regular S3 Minimally significant labels Mar 11, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.0 milestone Mar 11, 2024
@roman-khimov roman-khimov added I4 No visible changes and removed I3 Minimal impact labels Mar 11, 2024
@roman-khimov roman-khimov modified the milestones: v0.106.0, v0.107.0 May 15, 2024
@AnnaShaleva AnnaShaleva modified the milestones: v0.107.0, v0.106.1 May 21, 2024
@AliceInHunterland AliceInHunterland mentioned this issue May 31, 2024
Merged
@roman-khimov roman-khimov modified the milestones: v0.106.1, v0.106.2 Jun 1, 2024
AliceInHunterland added a commit that referenced this issue Jun 5, 2024
@AliceInHunterland
wallet: do not store deployed contract script inside Contract account
25d9624 
`Contract` account field should not contain deployed contract script.

Close #3348

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Jun 5, 2024
@AliceInHunterland
wallet: do not store deployed contract script inside Contract account
bb2d060 
`Contract` account field should not contain deployed contract script.

Close #3348

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Jun 5, 2024
@AliceInHunterland
wallet: do not store deployed contract script inside Contract account
b4fdf8c 
`Contract` account field should not contain deployed contract script.

Close #3348

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
bug Something isn't working I4 No visible changes S3 Minimally significant U3 Regular wallet NEP-6 wallet and accounts
Projects
None yet
Milestone
v0.106.2
Development

Successfully merging a pull request may close this issue.

wallet: do not store deployed contract script inside Contract account field nspcc-dev/neo-go
3 participants
@roman-khimov @AnnaShaleva @AliceInHunterland