-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Race in TestAwaitUtilCancelTx
caused by the test design
#3365
Labels
Milestone
Comments
AnnaShaleva
added
bug
Something isn't working
test
Unit tests
U2
Seriously planned
S4
Routine
I4
No visible changes
labels
Mar 19, 2024
AliceInHunterland
added a commit
that referenced
this issue
Mar 20, 2024
Occasionally the block is being accepted right after main transaction submission. Added two branches into this TestAwaitUtilCancelTx. One branch handles the case of original transaction acceptance, the other branch handles the conflicting transaction acceptance. Close #3365 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
added a commit
that referenced
this issue
Mar 22, 2024
Occasionally the block is being accepted right after main transaction submission. Added two branches into this TestAwaitUtilCancelTx. One branch handles the case of original transaction acceptance, the other branch handles the conflicting transaction acceptance. Close #3365 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
added a commit
that referenced
this issue
Mar 22, 2024
Occasionally the block is being accepted right after main transaction submission. Added two branches into this TestAwaitUtilCancelTx. One branch handles the case of original transaction acceptance, the other branch handles the conflicting transaction acceptance. Close #3365 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Not fixed, failure discovered in #3387 rebased onto fresh master. The error is:
|
AnnaShaleva
added a commit
that referenced
this issue
Apr 1, 2024
Always return "Target transaction accepted" if the target transation was either accepted by the moment of command run or during the command handling. Exit with code 0 in both cases. Adjust TestAwaitUtilCancelTx correspondingly, allow both cases in test. Close #3365. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this issue
Apr 1, 2024
Always return "Target transaction accepted" if the target transation was either accepted by the moment of command run or during the command handling. Exit with code 0 in both cases. Adjust TestAwaitUtilCancelTx correspondingly, allow both cases in test. Simplify the test along the way, remove useless code. Close #3365. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this issue
Apr 2, 2024
Always return "Target transaction accepted" error if the target transation was either accepted by the moment of command run or during the command handling. Exit with code 1 in both cases. Adjust TestAwaitUtilCancelTx correspondingly, allow both cases in test. Simplify the test along the way, remove useless code. Close #3365. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this issue
Apr 2, 2024
Always return "Target transaction accepted" error if the target transation was either accepted by the moment of command run or during the command handling. Exit with code 1 in both cases. Adjust TestAwaitUtilCancelTx correspondingly, allow both cases in test. Simplify the test along the way, remove useless code. Close #3365. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Fails with another error case after the last fix. Discovered in #3385.
|
AnnaShaleva
added a commit
that referenced
this issue
Apr 3, 2024
Close #3365. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
https://github.com/nspcc-dev/neo-go/actions/runs/8999180144/job/24720829287?pr=3431
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TestAwaitUtilCancelTx
is failing sometimes because of the fact that original transaction is being accepted instead of conflicting one. It happens because chain executor's chain continiousely produces blocks, so occasionally the block is being accepted right after main transaction submission. Go 1.22, macOS, firstly discovered at https://github.com/nspcc-dev/neo-go/actions/runs/8328012697/job/22787046121?pr=3357.The possible solution is to add two branches into this test. One branch should handle the case of original transaction acceptance, the other branch should handle the conflicting transaction acceptance. This situation is very natural, so let the test follow both cases (similar to the way how
TestWalletClaimGas
works.The text was updated successfully, but these errors were encountered: