Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify native's ActiveIn behaviour #3445

Open
AnnaShaleva opened this issue May 17, 2024 · 0 comments
Open

Simplify native's ActiveIn behaviour #3445

AnnaShaleva opened this issue May 17, 2024 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes S2 Regular significance U3 Regular
Milestone

Comments

@AnnaShaleva
Copy link
Member

Native deploy and update code becomes more complicated after #3444. A lot of problems causes nullable native's ActiveIn:

// ActiveIn returns the hardfork native contract is active starting from or nil in case
// it's always active.
ActiveIn() *config.Hardfork

If we use config.HFDefault instead of null ActiveIn and make ActiveIn to return config.Hardfork instead of *config.Hardfork, it will simplify things a lot and allow to unify native deploy/update code.

@AnnaShaleva AnnaShaleva added U3 Regular enhancement Improving existing functionality S2 Regular significance I4 No visible changes labels May 17, 2024
@AnnaShaleva AnnaShaleva added this to the v0.107.0 milestone May 17, 2024
@AnnaShaleva AnnaShaleva changed the title Refactor native's ActiveIn behaviour Simplify native's ActiveIn behaviour May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes S2 Regular significance U3 Regular
Projects
None yet
Development

No branches or pull requests

1 participant