Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-share stopped working with react/ react-dom 17.0.2, and broken style text block showing in the twitter page #514

Open
jobinkurianm opened this issue Nov 28, 2023 · 6 comments

Comments

@jobinkurianm
Copy link

jobinkurianm commented Nov 28, 2023

It looks like problem is with decoding '=' in the share url, (https://twitter.com/intent/tweet?url=https%3A%2 ..)

if we replace url= with url= this will work

image

@jobinkurianm jobinkurianm changed the title react-share stoped working with react/ react-dom 17.0.2, and broken style text block showing in the twitter page react-share stopped working with react/ react-dom 17.0.2, and broken style text block showing in the twitter page Nov 28, 2023
@ericasberry
Copy link

I'm seeing the same issue and also observed the broken url parameter and that entering the corrected (decoded) URL in the browser works.

@nygardk
Copy link
Owner

nygardk commented Nov 28, 2023

Hello! Could you create a code sandbox for this issue?

@jobinkurianm
Copy link
Author

Looks like sandbox blocked twitter url, Please see sample project in stackblitz

https://stackblitz.com/edit/stackblitz-starters-n8mswj

Tried different version of react-share with react/ react-dom 17.0.2, but no luck.

@rahulkarasiTtn
Copy link

Please update the version of react-share, it is fixed in the latest version.

@iamamyaman
Copy link

I am using the latest version still this issue is there @rahulkarasiTtn

@ashraf-gemini
Copy link

ashraf-gemini commented Nov 30, 2023

@rahulkarasiTtn I can double you on that, the latest release does address the twitter share fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants