Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add asset-registry migration for XCMv4 multilocations #1002

Closed
wischli opened this issue May 14, 2024 · 5 comments
Closed

Comments

@wischli
Copy link
Contributor

wischli commented May 14, 2024

When this repository started supporting XCMv3 as part of the update to Polkadot v0.9.38 in #886, the storage version of the asset registry was bumped and a migration was added to migrate v2 locations to v3.

I was wondering whether there are any plans to do the same for XCMv4 which was introduced in Polkadot SDK v1.7.0.

@xlc
Copy link
Member

xlc commented May 14, 2024

There is no reason to migrate to v4, which is exactly the same as v3 other than version bump and rename. Best to wait for V5 and migrate to it instead.

@lemunozm
Copy link
Contributor

To interact through the asset_registry traits (Inspect and Mutate), the API expects V4, but the orml_asset_registry implementation uses V3 under the hood. Do you know if all V4 locations can be internally translated to V3? Or should I expect i.e. that calling Inspect::metadata_by_location() can fail for some V4 Location?

@xlc
Copy link
Member

xlc commented May 27, 2024

the only thing changed is version number and otherwise 100% compatible

@lemunozm
Copy link
Contributor

Thanks for the double-checking!

@wischli
Copy link
Contributor Author

wischli commented May 27, 2024

Closing due to the isometry between V3 and V4 xcm locations. Thanks for your answers @xlc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants