Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nest_asyncio from bittensor to allow uvloop support #1839

Open
mjurbanski-reef opened this issue May 3, 2024 · 0 comments
Open

Remove nest_asyncio from bittensor to allow uvloop support #1839

mjurbanski-reef opened this issue May 3, 2024 · 0 comments
Assignees
Labels
feature new feature added

Comments

@mjurbanski-reef
Copy link
Contributor

mjurbanski-reef commented May 3, 2024

Is your feature request related to a problem? Please describe.

Uvloop, which provides supperior speed, does not allow loop nesting.

It is also the case that uvloop is pulled in by popular packages, which forces some subnets develop hacks to combat this.

And perhaps more importantly, https://github.com/erdewit/nest_asyncio seems to have been abandodend

Describe the solution you'd like

Remove nest_asyncio, and let bittensor users decide which asyncio loop they want to run. Perhaps even suggest (not mandate) running uvloop, since it consistently shows better results in benchmarks than CPython asyncio stdlib loop.

Seems like there was some attempt of this in the past #1501 for some reason (?)

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature added
Projects
None yet
Development

No branches or pull requests

2 participants