Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISSING : prerm function - Needed for DKMS packages and some others. #1039

Closed
Xdavius opened this issue Feb 11, 2024 · 5 comments
Closed

MISSING : prerm function - Needed for DKMS packages and some others. #1039

Xdavius opened this issue Feb 11, 2024 · 5 comments
Assignees
Labels
chore enhancement New feature or request triage Priority not yet decided

Comments

@Xdavius
Copy link

Xdavius commented Feb 11, 2024

Is your feature related to a problem? Please describe.

Cannot use dkms remove for dkms packages

A clear and concise description of what you want to happen.

I need the possibility to use pre_remove() function as it is the normal way to do

Describe alternatives you've considered

I use this tweak in prepare() but it's bad :

variables for DKMS remove are not setted if I use $DKMS_NAME so need to write in hard. Don't know why

#fix prerm script

sudo mkdir -p "${pkgdir}/DEBIAN/"
    echo "set -e

DKMS_NAME=nvidia
DKMS_PACKAGE_NAME=$DKMS_NAME-dkms
DKMS_VERSION=545.29.06

dkms remove -m nvidia -v 545.29.06 --all || true" | sudo tee ${pkgdir}/DEBIAN/prerm
sudo chmod +x ${pkgdir}/DEBIAN/prerm

Additional context

I am packaging Nvidia-driver for Debian, from the .run

I have other DKMS to package.

For the momment, keep them in tests in my own repository.

@Xdavius Xdavius added enhancement New feature or request triage Priority not yet decided labels Feb 11, 2024
@Xdavius
Copy link
Author

Xdavius commented Feb 11, 2024

Debian wiki page for this :
https://wiki.debian.org/KernelDKMS

Full project for nvidia-driver-bin here :
https://github.com/Xdavius/vortex-linux/tree/main/vortex-repository/pacscript/packages

@Elsie19
Copy link
Member

Elsie19 commented Feb 12, 2024

This will be added in 5.0.0.

@Xdavius
Copy link
Author

Xdavius commented Feb 12, 2024

This will be added in 5.0.0.

Very very good news!!!!

@oklopfer
Copy link
Member

oklopfer commented Apr 3, 2024

solved in #1055 btw

@oklopfer oklopfer added the chore label Apr 3, 2024
@oklopfer
Copy link
Member

@Xdavius this is available with pre_remove(), are we good to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request triage Priority not yet decided
Projects
None yet
Development

No branches or pull requests

4 participants