Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delete_after_merge option #212

Open
asvoboda opened this issue Nov 19, 2020 · 4 comments · May be fixed by #243
Open

Remove delete_after_merge option #212

asvoboda opened this issue Nov 19, 2020 · 4 comments · May be fixed by #243

Comments

@asvoboda
Copy link
Member

asvoboda commented Nov 19, 2020 •
edited

GH now supports automatically deleting branches (as of 2.22.4), so Bulldozer no longer needs to support the delete_after_merge option.

We can probably remove the supporting code and leave the option around, if we don't want to break any config changes:

bulldozer/bulldozer/merge.go

Lines 215 to 216 in a495289

if mergeConfig.DeleteAfterMerge {
attemptDelete(ctx, pullCtx, head, merger)

@anishagg17
Copy link

Hi @asvoboda, I would like to work upon this issue if there's no one assigned to this one

@asvoboda
Copy link
Member Author

Sure thing. Feel free to submit a PR and we can review.

@anishagg17 anishagg17 linked a pull request Apr 23, 2021 that will close this issue
Open
@xero-timothy
Copy link

Can I please object to this? Github Enterprise doesn't support this yet, and this is a nice feature for those of us stuck on GHE.

@asvoboda
Copy link
Member Author

Hey @xero-timothy,

Your concern is one of the reasons we haven't yet merged this change. GHE_ does_ support the delete-after-merge option natively as of 2.21.0. However, based on our internal testing the feature was broken in 2.21.3 and not fixed until 2.22.4.

As it stands, it probably doesn't hurt to keep this redundant feature around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove delete_after_merge functionality anishagg17/bulldozer
3 participants
@asvoboda @anishagg17 @xero-timothy