Add implementation of Decode for Box<str> and Box<[T]> #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Jan 12, 2024
bkchr
reviewed
Jan 12, 2024
src/codec.rs
Outdated
| @@ -1058,6 +1058,18 @@ impl Encode for str { | |||
| } | |||
| } | |||
|
|
|||
| impl Decode for Box<str> { | |||
| fn decode<I: Input>(input: &mut I) -> Result<Self, Error> { | |||
| Ok(String::decode(input)?.into_boxed_str()) | |||
There was a problem hiding this comment.
Can you check the already existing Box Decode implementation. It should be in the same way as this implementation.
There was a problem hiding this comment.
Do you think that decoded String will have some excess capacity or will it have capacity == len?
There was a problem hiding this comment.
I've taken a bit different route here
There was a problem hiding this comment.
should I maybe use WrapperTypeDecode like this:
impl WrapperTypeDecode for Box<str> {
type Wrapped = String;
fn decode_wrapped<I: Input>(input: &mut I) -> Result<Self, Error> {
// Guaranteed to create a Vec with capacity == len
let vec = Vec::from(Box::<[u8]>::decode(input)?);
// Guaranteed not to reallocate the vec, only transmute to String
let str = String::from_utf8(vec).map_err(|_| "Invalid utf8 sequence")?;
// At this point we have String with capacity == len,
// therefore String::into_boxed_str will not reallocate
Ok(str.into_boxed_str())
}
}
mversic
force-pushed
the
boxed_slice
branch
3 times, most recently
from
984c99c
to
c1b1067
Compare
koute
reviewed
Feb 5, 2024
koute
reviewed
Feb 5, 2024
mversic
force-pushed
the
boxed_slice
branch
2 times, most recently
from
5460a6d
to
23abd83
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
|
hi, this PR should be ready for merge. Can someone approve it now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #564
I can't think of a way to implement
Decodefor all unsized types