Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: remove rate-limit middleware #4420

Open
niklasad1 opened this issue May 9, 2024 · 0 comments
Open

rpc: remove rate-limit middleware #4420

niklasad1 opened this issue May 9, 2024 · 0 comments

Comments

@niklasad1
Copy link
Member

niklasad1 commented May 9, 2024

Currently, we have added simple RPC rate-limit middleware and a couple of CLI flags to whitelist for "trusted peers" but it's not ideal to have this logic in the node itself because it could be handled by a separate proxy but most proxies works on the HTTP layer and not when connection has been upgraded to WebSocket connection. That's why it's currently deeply integrated in the node itself to limit individual RPC calls and not per connection basis.

https://github.com/AcalaNetwork/subway is very promising RPC proxy that support websocket connections and it provides much features such as caching, merging subscription and rate-limiting.

Once we have tested/some confidence that it works with rpc spec v2 impl then this code in substrate should be removed.

Originally posted by @niklasad1 in #3701 (comment)

/cc @PierreBesson @BulatSaif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant