[draft] open on different OS #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimterry
requested changes
Apr 7, 2018
There was a problem hiding this comment.
Good core logic, but I'd like to tweak the structure a little.
Also the tests are failing. You'll need to update the stubbing here:
Lines 7 to 8 in 04ee8af
I think changing that to
xdg-open and also stubbing $OS to Linux is probably the way to go.
notes
Outdated
| OS=`uname -s` | ||
| [[ $OS = "Linux" ]] && open() { xdg-open "$@"; } | ||
| # Windows versions have NT in them | ||
| [[ $OS = *NT* ]] && open() { false; } # how do I invoke windows commands ? |
There was a problem hiding this comment.
I think:
- We should do this inside
open_note, rather than here. As-is, we'll runosname -sany time you run any command, which is just a bit wasteful, and it's not clear what the code inopen_noteis really doing now (it looks like it actually callsopen, but it's really using this logic instead) - We should explicitly handle OSX here, which really does use
open(that was what this code originally targeted). Looks like you're essentially handling that as a fallback case? Nicer to be clearer. - For versions where we don't know what to do (Windows), we should print a nice message and
exit 1, with something like:Opening your notes directory is not supported on your platform ($OS). Do you know how we can support this? Open an issue! https://github.com/pimterry/notes/issues/new
There was a problem hiding this comment.
Yes you are right, we should stuff the checks inside open_note(), The current approach was a mistake, I should have checked where open() was being called before wrapping. (Note: I checked it now :)
As for the test cases, I'll have to look, why they are failing and what those test cases are for in the first place. 😅
Thanks for the feedback :)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #57
Closes #57
Checklist
I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
I updated my branch with the master branch.
I have added the necessary testing to prove my fix is effective or my feature work, or I did not modify functionality.
I have added necessary documentation about the functionality in an appropriate .md file
I have commented any code I have modified or I did not modify any code
I would prefer the approach of definingopen()based on the OSPR summary
not implemented yet. In here for discussion