Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: Accept PASSWORD REQUIRE CURRENT DEFAULT #53306

Merged
merged 4 commits into from
Jun 2, 2024
Merged

parser: Accept PASSWORD REQUIRE CURRENT DEFAULT #53306

merged 4 commits into from
Jun 2, 2024
+4,159 −4,101

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented May 15, 2024

What problem does this PR solve?

Issue Number: close #53305

Problem Summary:

  1. This only accepts CREATE USER ... PASSWORD REQUIRE CURRENT DEFAULT. It doesn't support PASSWORD REQUIRE CURRENT OPTIONAL.
  2. This isn't stored, checked or validated.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

TiDB now accepts `PASSWORD REQUIRE CURRENT DEFAULT` as part of `CREATE USER` to aid MySQL 8.0 compatibility

@ti-chi-bot ti-chi-bot bot added release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 15, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 15, 2024

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor Author

dveeden commented May 15, 2024

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.2115%. Comparing base (afd2343) to head (896921a).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53306        +/-   ##
================================================
+ Coverage   72.5370%   75.2115%   +2.6744%     
================================================
  Files          1506       1507         +1     
  Lines        430741     435622      +4881     
================================================
+ Hits         312447     327638     +15191     
+ Misses        98968      88192     -10776     
- Partials      19326      19792       +466
Flag Coverage Δ
integration 50.0484% <ø> (?)
unit 71.9804% <ø> (+0.4509%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4280% <ø> (+8.6228%) ⬆️

CbcWestwolf
CbcWestwolf approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@CbcWestwolf CbcWestwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lastincisor
lastincisor approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@lastincisor lastincisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2024

@lastincisor: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor Author

dveeden commented May 22, 2024

cc @yudongusa @easonn7

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2024

@ljun0712: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ljun0712
Copy link

LGTM（This PR is only for syntax compatibility with MySQL.）

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-16 02:18:56.928392048 +0000 UTC m=+1706090.685527620: ☑️ agreed by CbcWestwolf.
  • 2024-05-29 10:16:29.527691267 +0000 UTC m=+2857943.284826840: ☑️ agreed by tangenta.

@easonn7
Copy link

easonn7 commented Jun 2, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, easonn7, lastincisor, ljun0712, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2069651 into pingcap:master Jun 2, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@tangenta tangenta tangenta approved these changes

@lastincisor lastincisor lastincisor approved these changes

@ljun0712 ljun0712 ljun0712 approved these changes

@BornChanger BornChanger Awaiting requested review from BornChanger

Assignees

@tangenta tangenta

@BornChanger BornChanger

Labels
approved component/parser lgtm ok-to-test release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user password options not compatible with MySQL
7 participants
@dveeden @ljun0712 @easonn7 @CbcWestwolf @tangenta @lastincisor @BornChanger