-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date range table filter in Ant Design is broken #5933
Comments
@StariMarco, thanks for the issue 👋 I will look into it |
I'm a newcomer to refine. I've managed to replicate the bug, and I'm now investigating it to create a solution as part of my exploration of the code. If that is okay? Thank you 😄 |
Hello @frank-mendez, We are open to all contributions 🙌 Thanks for improving Refine. If you want I can assign this issue to you. |
Hey @alicanerdurmaz I can also contribute to this issue, I have reproduced the issue and also looking for the fix. If you don't mind can you assign it to me? |
Hello @rohitlohar45, I am glad to hear that but since @frank-mendez wrote earlier, it would be better to assign it to him. Unfortunately, I replied to @frank-mendez too late, so he might have given up on doing the task. Let's wait until tomorrow and if we don't get an answer I'll be happy to assign it to you. |
No problem, actually have a workaround in my mind by back tracking the code. Would help even if I don't get assigned to this |
@rohitlohar45 Thanks, I assigned it to you |
I had a doubt that do refine handle the graphQl requests while filtering if so where it is handling it because the main issue is that in filters field the expected format is not sent and hence this error is received. |
@frank-mendez, @rohitlohar45 Thanks for detailed explanation. I think there is a problem in the process of encoding filters to string or parsing from string to filters. Code is here. I'll debug and let you know what I find. |
@alicanerdurmaz, Can you please check this PR: #5961 this solution is working fine, but not sure that have I maintained proper developer practices. |
Describe the bug
Hi everyone, while trying to replicate the Ant Design Crm example I noticed that the date range filter doesn't work as it should: https://example.crm.refine.dev/administration/audit-log.
When filtering by the "Date & Time" column and subsequently reloading the page, the following error occurs:
Then if you try to filter the same column again, the application will crash.
Other types of filters work properly, so I think that there might be something wrong with the conversion of the date values from the url to CrudFilter objects or vice-versa.
Here's a video of the bug:
Example.mp4
Steps To Reproduce
Expected behavior
Upon reloading the page with the same URL, the "Date & Time" column should be filtered with valid dates, and the query should function correctly.
Packages
Additional Context
No response
The text was updated successfully, but these errors were encountered: