Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract some parts of this project as separate npm packages #31

Open
brunoluiz opened this issue Aug 11, 2021 · 2 comments
Open

Extract some parts of this project as separate npm packages #31

brunoluiz opened this issue Aug 11, 2021 · 2 comments

Comments

@brunoluiz
Copy link

brunoluiz commented Aug 11, 2021

I came across this repository while reading the Chainlink documentation about how to set it up with Hardhat. I gotta say you guys did an amazing job setting this up.

I see some bits of it could be extracted in separate npm packages, which could be used in existing set-ups (when someone doesn't start from this project):

  • Network configs and auto-funding logic: could be probably even shared with the truffle set-up
  • Tasks into a hardhat plugin
  • A new task to generate mock contracts and basic deployment scripts (I believe you can't have contracts and deployments as a plugin), somewhat in Golang generator fashion.

If you guys think it might be a good idea, let me know. I am more than happy to help with this.

The repository could still be used as reference of the final implementation though.

@pappas999
Copy link
Collaborator

hi @brunoluiz thanks for raising this. I think it's a fantastic idea. Turning some of these things into plugins is something we've had on the to-do list a while, and we'd love to get help from the community in helping to improve these kits

@brunoluiz
Copy link
Author

@pappas999 Yeah, makes sense.

Could you guys create a mono repository (lerna perhaps) in this GH account (@smartcontractkit), so people could open PRs on top of that repository? This way you guys will always be able to audit what is being pushed, so no sketchy package is used by developers later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants