-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move libsecp256k1 calls to separate package #9006
Comments
I strongly think it should have a distinct name. For example, coincurve is a good name because you can easily distinguish it from rusty's secp bindings.
Right, to make the new package useful, I think it should
|
|
Currently, some projects such as
python-nostr
usecffi
based python packages such assecp256k1
orcoincurve
. In contrast, Electrum usesctypes
in order to calllibsecp256k1
functions inecc.py
andecc_fast.py.
It would make sense to create a standalone python package for that. That package could be used by other projects, and it would free those projects from importingcffi
related dependencies.Note that some of the methods in
ecc.py
use cryptography (encrypt_message
,verify_message
). I think we should not import cryptography in the new package, but rather move those methods toelectum/crypto.py
.Not sure how to name the new package. IMaybe
python-libsecp256k1
?The text was updated successfully, but these errors were encountered: