Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@JvmStatic missing for @DynamicPropertySource in @Testcontainers #40823

Closed
erie0210 opened this issue May 20, 2024 · 2 comments
Closed

@JvmStatic missing for @DynamicPropertySource in @Testcontainers #40823

erie0210 opened this issue May 20, 2024 · 2 comments
Assignees
@erie0210
Labels
status: superseded An issue that has been superseded by another

Comments

@erie0210
Copy link
Contributor

erie0210 commented May 20, 2024 •
edited by philwebb

Looks like @JvmStatic is missing for @DynamicPropertySource in @Testcontainers docs kotlin example. It should be static with @DynamicPropertySource according to its docs.

Also, there is no kotlin example for Testcontainers in spring boot reference docs.

I'd like to work on both of them if it needs to be done. :)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 20, 2024
@wilkinsona
Copy link
Member

wilkinsona commented May 20, 2024 •
edited

That'd be great. Thanks, @erie0210.

@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels May 20, 2024
@wilkinsona wilkinsona added this to the 3.1.x milestone May 20, 2024
@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.2.x May 23, 2024
@erie0210 erie0210 mentioned this issue May 26, 2024
Closed
@scottfrederick
Copy link
Contributor

Closing in favor of #40905

@scottfrederick scottfrederick closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
@scottfrederick scottfrederick added status: superseded An issue that has been superseded by another and removed type: documentation A documentation update labels May 28, 2024
@scottfrederick scottfrederick removed this from the 3.2.x milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erie0210 erie0210

Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Kotlin example for @Testcontainers erie0210/spring-boot
5 participants
@scottfrederick @wilkinsona @spring-projects-issues @erie0210 @mhalbritter