Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e10s: browsers[i].contentDocument is null #313

Open
M0ns1gn0r opened this issue Apr 12, 2017 · 5 comments
Open

e10s: browsers[i].contentDocument is null #313

M0ns1gn0r opened this issue Apr 12, 2017 · 5 comments

Comments

@M0ns1gn0r
Copy link

On FF 52.0.02 (32-bit) after I force-enabled e10s it is not more possible to write new styles. The browser console shows up the following message when I click "Write new style -> For github.com":

TypeError: browsers[i].contentDocument is null common.js:74:10
  stylishCommon.focusWindow chrome://stylish/content/common.js:74:10
  stylishCommon.openEdit chrome://stylish/content/common.js:92:7
  stylishCommon.addCode chrome://stylish/content/common.js:324:3
  stylishOverlay.addCode chrome://stylish/content/overlay.js:457:3
  stylishOverlay.addDomain chrome://stylish/content/overlay.js:453:3
  stylishOverlay.getDomainMenuItem/< chrome://stylish/content/overlay.js:422:51

P.S. As a workaround I add styles manually via editing the sqlite database.

@reallyuniquename
Copy link

reallyuniquename commented May 1, 2017

Firefox 52.1.0 ESR. Pressing Edit button in styles list does nothing, same error in console.

@reallyuniquename
Copy link

Apparently this is the issue: #293

@Mathnerd314
Copy link

Mathnerd314 commented May 13, 2017

I'm using today's Nightly, workaround seems to be opening chrome://stylish/content/edit.xul?id=. It prints out this error message a lot when saving, probably from here:

mozilla::storage::Statement::BindInt32Parameter is deprecated and will be removed soon.
mozilla::storage::Statement::BindStringParameter is deprecated and will be removed soon.

Of course none of it matters, I'm pretty sure the Chrome addon is a better starting point for a WebExtension.

@mzso
Copy link

mzso commented May 21, 2017

I don't get it. For me this only started happening at most three days agon on mozilla-central.
Until then it was working, with E10s on.

@mzso
Copy link

mzso commented May 21, 2017

@Mathnerd314 commented on 2017. máj. 14. 00:56 CEST:

Of course none of it matters, I'm pretty sure the Chrome addon is a better starting point for a WebExtension.

Yeah, well not everyone will continue on with FF57. And it would be nice to have Stylish functioning up to v56. So it matters to me. :)
(Also, I'm using stylish mostly for GUI customization, so a WE version won't help me.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants