Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker INPUT is too short #83

Open
hideheader opened this issue Dec 20, 2015 · 4 comments
Open

Color picker INPUT is too short #83

hideheader opened this issue Dec 20, 2015 · 4 comments

Comments

@hideheader
Copy link

The INPUT permits 7 characters ('#234567'), but the longest color name is 20 characters ('lightgoldenrodyellow').

Also, 'transparent' should be added to the color names. It's easily the most versatile of them all.

@JasonBarnabe
Copy link
Contributor

It's designed to accept only RGB values. This is partially because the color picker only considers RBG to be correct. #44

@hideheader
Copy link
Author

No. In fact, every color name is in the caboodle except rebeccapurple, which we can do without.
https://github.com/JasonBarnabe/userstyles/blob/master/public/javascripts/jscolor.js#L512-L514

@JasonBarnabe
Copy link
Contributor

Yes. In fact, that's the code I added in #44 that only added partial support.

@hideheader
Copy link
Author

And it's great code, really it is, but unless maxlength is increased from 7 to 20 on INPUT.color then it isn't possible to type in all of the color names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants