-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Unable to interact with ktistec users #2857
Comments
Thanks! I'll see if we can rejig our signature without breaking compatibility for anything else. Didn't realize |
It's recommended, not required, so any implementation that aims to correctly implement the spec should accept a signature without that field.
The last bit is kinda crucial:
GtS is able to control that header just fine, and we do. It's hopefully not too much faff to add the attribute on our side, but implementing a stricter requirement than the spec is a bug, at least from an interoperability point of view. |
Hiya! Reopening this because we had to roll back |
Describe the bug with a clear and concise description of what the bug is.
I send a follow request to a ktistec user, and he didn't receive that.
Ktistec requires
(created)
http signature header.Gts' implemetation doesn't include it:
gotosocial/internal/transport/signing.go
Lines 28 to 29 in b7c629a
Mastodon attempts to use the
(created)
header first, fallback to theDate
header if not present.The spec draft recommends using the
created
signature parameter (not required)Log
From Gts server:
timestamp="21/04/2024 20:46:22.302" func=workers.(*clientAPI).CreateFollowReq level=ERROR requestID=v9vv204f040018tk485g msg="error federating follow request: Follow: error sending activity *typefollow.ActivityStreamsFollow via outbox https://moe.reisen/users/lindsay/outbox: func1: error delivering to https://qaq.land/actors/qaq/inbox: deliver: POST request to https://qaq.land/actors/qaq/inbox failed: status=\"400 Bad Request\" body=\"{\"msg\":\"can't be verified\"}\""
From
Ktistec
server:What's your GoToSocial Version?
v0.15.0
GoToSocial Arch
x86_64 Binary
What happened?
No response
What you expected to happen?
No response
How to reproduce it?
No response
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: