You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we allow bilara files of the same text to omit segment IDs. This is handy, especially for things like references and variants where there are only a few items. However, it has created issues for us in development. For example, it makes it complicated to test for segment correctness and sort order.
After discussion with STXnext, we propose to ensure that every instance of the same text has the same segment IDs, with no omissions permitted.
this applies to everything in Bilara, i.e. to texts as well as to site, blurbs, name, etc.
even if there is only one item in a file of a thousand segment IDs, we have to list them all!
We currently allow full segment identity, but do not enforce it. So this will not introduce new situations, merely reduce some flexibility. Therefore I expect that generally this should not cause problems in our systems.
Nonetheless, the world is a weird and wonderful place so we should make sure we test it out well!
This will affect all the apps downstream of bilara-data:
SC
Voice
Publications
Third party apps
We will develop this initially in the new Bilara 2.0. Once that is ready we can test in other scenarios.
This would allow us to delete the merging code in Voice since not all translations have the same segments. Thanks for the notification.
... I have a vague memory that Ven. Brahmali may have added extra segments (i.e., more segments than root). If so, then this might adversely impact his translations.
Currently we allow bilara files of the same text to omit segment IDs. This is handy, especially for things like references and variants where there are only a few items. However, it has created issues for us in development. For example, it makes it complicated to test for segment correctness and sort order.
After discussion with STXnext, we propose to ensure that every instance of the same text has the same segment IDs, with no omissions permitted.
We currently allow full segment identity, but do not enforce it. So this will not introduce new situations, merely reduce some flexibility. Therefore I expect that generally this should not cause problems in our systems.
Nonetheless, the world is a weird and wonderful place so we should make sure we test it out well!
This will affect all the apps downstream of bilara-data:
We will develop this initially in the new Bilara 2.0. Once that is ready we can test in other scenarios.
example
Let us take sn6.7 as an example.
current
sn6.7_html.json:
sn6.7_root-pli-ms.json:
sn6.7_variant-pli-ms.json:
sn6.7_reference.json:
proposed
In this case, root and html are unchanged, but variant and reference have segments with empty values assigned.
sn6.7_html.json:
sn6.7_root-pli-ms.json:
sn6.7_variant-pli-ms.json:
sn6.7_reference.json:
The text was updated successfully, but these errors were encountered: