Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The journal socket should be mounted automatically if MountAPIVFS= is applied and StandardOutput/Error=journal #32478

Open
DaanDeMeyer opened this issue Apr 25, 2024 · 2 comments · May be fixed by #32487
Open

The journal socket should be mounted automatically if MountAPIVFS= is applied and StandardOutput/Error=journal #32478

DaanDeMeyer opened this issue Apr 25, 2024 · 2 comments · May be fixed by #32487
Labels
pid1 RFE 🎁 Request for Enhancement, i.e. a feature request

Comments

@DaanDeMeyer
Copy link
Contributor

Component

systemd

Is your feature request related to a problem? Please describe

Currently, when MountAPIVFS= takes effect (either implicitly or explicitly) and the service is configured to log to the journal, we lose all logs from systemd-executor as it will neither be able to log to the console, nor will it be able to log to the journal.

Describe the solution you'd like

If a service is configured to log to the journal and we decide to mount in the APIVFS directories (because it has its own image or other reasons), we should automatically mount in the journal socket so that the service can log to the journal.

Describe alternatives you've considered

No response

The systemd version you checked that didn't have the feature you are asking for

main
@DaanDeMeyer DaanDeMeyer added the RFE 🎁 Request for Enhancement, i.e. a feature request label Apr 25, 2024
@github-actions github-actions bot added the pid1 label Apr 25, 2024
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 25, 2024
@YHNdnzj
core: introduce BindJournalSockets=
e666cd9 
Closes systemd#32478
@YHNdnzj YHNdnzj linked a pull request Apr 25, 2024 that will close this issue
Open
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 26, 2024
@YHNdnzj
core: introduce BindJournalSockets=
f701fa0 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 26, 2024
@YHNdnzj
core: introduce BindJournalSockets=
54f54c7 
Closes systemd#32478
@YHNdnzj YHNdnzj linked a pull request Apr 26, 2024 that will close this issue
core: introduce BindJournalSockets= #32487
Open
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 26, 2024
@YHNdnzj
core: introduce BindJournalSockets=
7b83347 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 26, 2024
@YHNdnzj
core: introduce BindJournalSockets=
0e8e53f 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 26, 2024
@YHNdnzj
core: introduce BindJournalSockets=
4bf703d 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 26, 2024
@YHNdnzj
core: introduce BindJournalSockets=
92e0580 
Closes systemd#32478
@poettering
Copy link
Member

I don't follow? What does MountAPIVFS= do precisely that would cause logging to fail? I don't see the connection?

@YHNdnzj
Copy link
Member

YHNdnzj commented Apr 26, 2024

I don't follow? What does MountAPIVFS= do precisely that would cause logging to fail? I don't see the connection?

exec_invoke enables log open_when_needed. Therefore, it requires access to the journal socket in the target root after switching into it, in order to log there.

YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 26, 2024
@YHNdnzj
core: introduce BindJournalSockets=
b502500 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 27, 2024
@YHNdnzj
core: introduce BindJournalSockets=
d0a4311 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue Apr 29, 2024
@YHNdnzj
core: introduce BindJournalSockets=
404f324 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue May 2, 2024
@YHNdnzj
core: introduce BindJournalSockets=
a1ee42c 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue May 8, 2024
@YHNdnzj
core: introduce BindJournalSockets=
3aef6cd 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue May 9, 2024
@YHNdnzj
core: introduce BindJournalSockets=
64dec60 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue May 9, 2024
@YHNdnzj
core: introduce BindJournalSockets=
186b088 
Closes systemd#32478
YHNdnzj added a commit to YHNdnzj/systemd that referenced this issue May 13, 2024
@YHNdnzj
core: introduce BindJournalSockets=
9cbe194 
Closes systemd#32478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pid1 RFE 🎁 Request for Enhancement, i.e. a feature request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: introduce BindJournalSockets= YHNdnzj/systemd
3 participants
@poettering @DaanDeMeyer @YHNdnzj