Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsock-mux ssh proxy #32941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

vsock-mux ssh proxy #32941

wants to merge 1 commit into from

Conversation

gdamjan
Copy link
Contributor

@gdamjan gdamjan commented May 20, 2024 •
edited by github-actions bot

allow the ssh-proxy to connect to cloud-hypervisor/Firecracker guests,
via their unix-domain socket to AF_VSOCK multiplex:

https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/docs/vsock.md
https://github.com/firecracker-microvm/firecracker/blob/main/docs/vsock.md

@github-actions github-actions bot added documentation please-review PR is ready for (re-)review by a maintainer labels May 20, 2024
@github-actions GitHub Actions
Copy link

Important

An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released.

poettering
poettering reviewed May 21, 2024
View reviewed changes
man/systemd-ssh-proxy.xml Outdated
@@ -24,7 +24,7 @@

<refsynopsisdiv>
<programlisting>
Host unix/* vsock/*
Host unix/* vsock/* vsock-indirect/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's quite hard to type. maybe use a shorter prefix?

maybe:

  • vsocki/…
  • ivsock/…
  • vsock-ep/… (for "entry point")

or so?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or vsockmux/*?

vsock-mux/*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsock-mux/ seems fine to me

@poettering
Copy link
Member

looks good, but some fixes please

@poettering poettering added reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks ssh-generator and removed please-review PR is ready for (re-)review by a maintainer labels May 21, 2024
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels May 21, 2024
@poettering
Copy link
Member

lgtm

@poettering poettering added good-to-merge/after-next-release and removed please-review PR is ready for (re-)review by a maintainer labels May 21, 2024
@poettering poettering added this to the v257 milestone May 21, 2024
@gdamjan gdamjan changed the title vsock-indirect ssh proxy vsock-mux ssh proxy May 21, 2024
@gdamjan
vsock-mux ssh proxy
fc09727 
allow the ssh-proxy to connect to cloud-hypervisor/Firecracker guests,
via their unix-domain socket to AF_VSOCK multiplexer:

https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/docs/vsock.md
https://github.com/firecracker-microvm/firecracker/blob/main/docs/vsock.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poettering poettering poettering left review comments

@YHNdnzj YHNdnzj YHNdnzj left review comments

@yuwata yuwata yuwata approved these changes

Assignees
No one assigned
Labels
documentation good-to-merge/after-next-release ssh-generator
Milestone
v257
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gdamjan @poettering @yuwata @YHNdnzj