You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Requires further review.
This is a minor but potentially BREAKING change.
Zero urgency, consider holding till next breaking set.
Before this commit:
Client-side `[:chsk/ws-ping]` events are wrapped to
`[:chsk/recv [:chsk/ws-ping]]` when `wrap-recv-evs?` is true.
After this commit:
Client-side `[:chsk/ws-ping` events are NOT wrapped, even
when `wrap-recv-evs?` is true.
MOTIVATION:
While `:chsk/ping` is indeed pushed from server, `:chsk/recv` is
in practice reserved for user-level events. Keeping it that way
may be better (more convenient for users).
Bug in
v1.19.2
:wrap-recv-evs?
option seems to unintentionally wrap pings when enabled.Ref. #436 (comment)
Update: actually need to properly consider what behaviour makes the most sense here.
The text was updated successfully, but these errors were encountered: