Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRCodes com.google.zxing.NotFoundException #367

Open
Suraku opened this issue Apr 19, 2024 · 1 comment
Open

QRCodes com.google.zxing.NotFoundException #367

Suraku opened this issue Apr 19, 2024 · 1 comment

Comments

@Suraku
Copy link

Suraku commented Apr 19, 2024

Hi
I've ran into an issue with QR code scanning not working on my OnePlus Nord CE 3 Lite.
Exception is triggered with com.google.zxing.NotFoundException within the QRCodes.kt file.

Error

I've had no issue with my older One Plus 6T, so I'm not sure if this is a newer model phone issue?

Thought I'd have a go at trying a fix, and came across using Google's ML-Kit for barcode scanning, which looks to have done the trick.

implementation("com.google.mlkit:barcode-scanning:17.2.0")

Code snippet:
MLKit

I'm not an Android developer, this is very much hacked together very roughly just as a POC to see if it fixes my issue, which it has.
I'm wondering if this would be a better approach?

@thunderbiscuit
Copy link
Owner

Hey thanks for reporting the bug! I'm not sure what could trigger the exception. But the ML-Kit library is something I'd be interested in exploring for sure.

Would you want to open a PR for it? My only reservation would be around bundle size. It looks like the mlkit library adds 2.4 MB to your app size (something like 20% increase of Padawan), which is too bad for just needing to scan a QR code once in a while. But the xzing library is old and it's given me plenty of trouble in the past. A new solution might be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants