Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot Right Click on Desktop using Chrome on ChromeOS #107

Open
markusbkk opened this issue Oct 20, 2022 · 3 comments
Open

[BUG] Cannot Right Click on Desktop using Chrome on ChromeOS #107

markusbkk opened this issue Oct 20, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@markusbkk
Copy link

Describe the bug
The right click context menu fails to appear under a ChromeOS client.

To Reproduce
Steps to reproduce the behavior:

  1. Launch ArOZ on ChromeOS
  2. Log in
  3. Right click on desktop

Expected behavior
The right click context menu should appear, allowing me to personalize the desktop.

Host Information(please complete the following information):

  • OS: Crostini (Debian GNU/Linux 11 Bullseye)
  • Go version: go1.19.1 linux/amd64
  • Arozos version: 1.124 (master branch)

Client Information(please complete the following information):

  • OS: ChromeOS 104.0.5112.110
  • Browser: Chrome
  • Version: 104.0.5112.110
  • User Agent: Mozilla/5.0 (X11; CrOS x86_64 14909.132.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36
@markusbkk
Copy link
Author

Just realized you're checking for a touch screen in some places.
The device I'm using is an Asus C302CA, so it happens to have a touch screen.

@tobychui
Copy link
Owner

Hi @markusbkk ,

I guess this might be an issue related to /web/desktop.system with the following line of code (Line 4856, ArozOS v2.005 internal preview)

} else if (clickTarget.hasClass("backgroundFrame") || ((isSafari || (isMacOS && isChrome)) && $(clickTarget).attr("id") == "selectionPanel")) {

As I don't have a touch screen chrome OS device, I think I might need your help to debug this. Can you add a condition in this line to detect your browser and see when this condition is satisfied, the right click issue goes away?

@markusbkk
Copy link
Author

markusbkk commented Oct 24, 2022

Hi @markusbkk ,

I guess this might be an issue related to /web/desktop.system with the following line of code (Line 4856, ArozOS v2.005 internal preview)

} else if (clickTarget.hasClass("backgroundFrame") || ((isSafari || (isMacOS && isChrome)) && $(clickTarget).attr("id") == "selectionPanel")) {

As I don't have a touch screen chrome OS device, I think I might need your help to debug this. Can you add a condition in this line to detect your browser and see when this condition is satisfied, the right click issue goes away?

Hey. Sorry. Didn't see your reply.
isChrome already validates to true.

I just noticed that right click does actually change the display: none to display: block inside the selectionPanel element, but then it returns to the original state within a split second.

EDIT: If I rename selectionPanel to anything else, the right click context menu opens as it should. I suspect this will break something else though.

There's some very strange behavior on ChromeOS in general. The wallpaper feature also doesn't work on here, whenever I pick a custom folder. Seems like Google is doing things specific to their own OS somewhere down the line that breaks even basic Chrome or GNU/Linux behavior.

EDIT2: NVM the wallpaper issue. It actually only malfunctions when the file ends in .jpeg. Even just changing it to .jpg works.

EDIT3 (final edit. Lol): Just realized that selectionPanel is the container that gets activated whenever one is attempting to drag and select a number of items, so not directly related to the context menu but somehow blocking the context menu from appearing on my device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants