-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google sign-in prompt shows up on some websites #2869
Comments
I don't think this is a part of browser interface. You can block third-party cookies for accounts.google.com to remove your account from this popup. Or use an ad blocking extension to hide this prompt and block third-party requests. |
@networkException @Ahrotahn Is it worth flipping this setting by default? |
With our changes the identity provider should return that the profile is not signed in. Granted, we should probably add that section to the UI removal patch since it doesn't, or at least shouldn't, do anything. I tested with my local linux build as well as the windows builds for 122.0.6261.94-1 and 124.0.6367.207-1 from our binaries page and I'm not able to reproduce this. Are you using a third-party build? Maybe they are not building with our sign-in changes. |
I tested https://github.com/ungoogled-software/ungoogled-chromium-windows/releases/tag/124.0.6367.207-1.1 - and indeed it turns out that the default setting is not what it should be: I confirm @Swarkin's point. |
@Rusenche The interface option for the setting existing wasn't in question. Can you reproduce the Google sign-in dialog this issue is about? |
I am using the windows build from the builds website linked in the readme on version 122 as that is the last version without the UI refresh.
I only imported a bookmark html file and the browser was one of the first things I installed on a fresh windows ltsc install, so no other browsers were present. |
I'll see what I can figure out. It might be better to remove fedcm functionality alltogether. |
OS/Platform
Windows
Installed
https://ungoogled-software.github.io/ungoogled-chromium-binaries/
Version
Version 122.0.6261.94 (Official Build, ungoogled-chromium) (64-bit)
Have you tested that this is not an upstream issue or an issue with your configuration?
--user-data-dir
command line argument and it could not be reproduced thereDescription
Google sign-in prompt shows up on some websites.
How to Reproduce?
Go to medium.com
Actual behaviour
Google sign-in prompt shows up on some websites.
Expected behaviour
I expected ungoogled-chromium to be ungoogled
Relevant log output
No response
Additional context
Is this left in for a reason? The browser managed to extract my account info from presumably YouTube and now shows it in a small popup when websites support Google sign-in.
The text was updated successfully, but these errors were encountered: