Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow Key Navigation #246

Open
lvegerano opened this issue Nov 3, 2022 · 5 comments
Open

Arrow Key Navigation #246

lvegerano opened this issue Nov 3, 2022 · 5 comments

Comments

@lvegerano
Copy link

Thanks for such a nice site. Here is some feedback.

I like to use my keyboard as much as I can. I'm disappointed every time I visit a site that has pagination and does not support paging with the arrow keys.

Thanks,

@jschr
Copy link
Member

jschr commented Nov 3, 2022

Thanks for the feedback!

Do you have any other keyboard shortcuts you'd like to see added to the site?

@lvegerano
Copy link
Author

None that come to mind.

Also, if you'd like I can work on this.

@jschr
Copy link
Member

jschr commented Nov 4, 2022

Unfortunately I didn’t have much time to set this project up for external contributions when I last worked on it. I definitely want to though and will try to find time to make it easy for others to contribute soon. Thanks for offering.

For keyboard pagination, do you have any examples of websites that you think do this well?

I’m a bit concerned about people unexpectedly navigating away. What do you think about having to scroll to the end of the page first (so pagination is in view) before the left/right keys can be used to go to the prev/next page?

@ykrx
Copy link

ykrx commented Nov 5, 2022

More possible hotkeys:

  • / / F: Toggle search bar focus
  • Opt (or some other modifier) + arrow keys: Move focus between themes, in-order as displayed on page

@lvegerano
Copy link
Author

lvegerano commented Dec 8, 2022

I’m a bit concerned about people unexpectedly navigating away. What do you think about having to scroll to the end of the page first (so pagination is in view) before the left/right keys can be used to go to the prev/next page?

I hear this... what about infinite scroll and removing pagination all together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants