Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web3-validator browser target removed #7016

Merged
merged 2 commits into from May 13, 2024

Conversation

PeKne
Copy link
Contributor

@PeKne PeKne commented Apr 30, 2024

Description

  • browser target was removed from web3-validator package since the referenced file is not included in the package

Fixes #7015

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls could you also mentioned this in web3-validator changelog that this bug is fixed, thanks

@PeKne PeKne force-pushed the fix/web3-validator-browser-dist-7015 branch from e4a46bf to dcdaf3c Compare May 9, 2024 06:29
@PeKne
Copy link
Contributor Author

PeKne commented May 9, 2024

@jdevcs

pls could you also mentioned this in web3-validator changelog that this bug is fixed, thanks

fixed by: dcdaf3c

@avkos avkos merged commit 0408125 into web3:4.x May 13, 2024
16 of 18 checks passed
@PeKne PeKne deleted the fix/web3-validator-browser-dist-7015 branch May 14, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing web3-validator/dist folder
3 participants