Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even shorter and more readable #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

drdla
Copy link

@drdla drdla commented Apr 8, 2019

No description provided.

@skratchdot
Copy link

skratchdot commented Apr 16, 2019

this pr will change the output of the function. if you call it with:

compact([1, 2, false, 45, undefined, 0])

existing code will return: [ 1, 2, 45, 0 ]
code from pr will return: [ 1, 2, 45 ]

i don't care (as I don't use this function), but it seems like a new test case should be added, because the 0 logic isn't being tested currently.

EDIT: the code from the PR seems to behave more like the documentation that states remove falsey values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants