Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUMP] Update dependency ember-template-lint to v6 (dossier racine) (PIX-12410) #593

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 5, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ember-template-lint ^5.0.0 -> ^6.0.0 age adoption passing confidence

Release Notes

ember-template-lint/ember-template-lint (ember-template-lint)

v6.0.0

Compare Source

💥 Breaking Change
  • #​3029 Enable more recommended rules: no-action-on-submit-button, no-at-ember-render-modifiers, no-builtin-form-components, no-unnecessary-curly-parens, no-unnecessary-curly-strings, simple-modifiers (@​bmish)
  • #​3031 Replace 4-x-recommended config with 5-x-recommended (@​bmish)
  • #​3023 Drop support for Node 14, 16, 19 (@​Techn1x)
  • #​2913 Add additional elements to DOCUMENT_STRUCTURE_ROLES for no-invalid-role rule (@​mrloop)
  • #​2729 Add param to obsolete list in no-obsolete-elements rule (@​geneukum)
🏠 Internal
Committers: 4

Tracking issue: https://github.com/ember-template-lint/ember-template-lint/issues/2712


Configuration

📅 Schedule: Branch creation - "every 1 hour every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Suppression d'un comportement qui ne me semble pas à être du ressort de la pagination. à voir si c'est ok sur les applications.

Tests :

npm pack du projet PixUI et installation du package comme définit dans la documentation PixUI

  • PixOrga
  • PixCertif
  • PixAdmin
  • PixApp
  • PixEditor ? 🤔

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 5, 2024
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr593.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-ui-review-pr593/environment

@xav-car xav-car force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch 6 times, most recently from 77c8caf to ae3201b Compare April 18, 2024 09:06
@xav-car xav-car force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch from ae3201b to 050c035 Compare April 29, 2024 13:44
@xav-car xav-car added the 🚧 Development in progress Work In Progress label Apr 29, 2024
@renovate renovate bot force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch 2 times, most recently from f58cbaf to 07c199e Compare May 2, 2024 09:33
@xav-car xav-car force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch from 07c199e to cebecc6 Compare May 2, 2024 12:26
Copy link
Contributor Author

renovate bot commented May 2, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@xav-car
Copy link
Contributor

xav-car commented May 2, 2024

A vérifier que les modifications apporté fonctionne correctement

@xav-car xav-car force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch from cebecc6 to 840ff93 Compare May 2, 2024 12:48
@xav-car xav-car added the cross-team Toutes les équipes de dev label May 2, 2024
@xav-car xav-car changed the title [BUMP] Update dependency ember-template-lint to v6 (dossier racine) [BUMP] Update dependency ember-template-lint to v6 (dossier racine) (PIX-12410) May 2, 2024
@xav-car xav-car self-assigned this May 3, 2024
@yannbertrand yannbertrand force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch from 840ff93 to ea51268 Compare May 7, 2024 17:46
@xav-car xav-car force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch from ea51268 to 1a5ea56 Compare May 13, 2024 07:57
@yannbertrand
Copy link
Member

A vérifier que les modifications apporté fonctionne correctement

Une reco de comment tester ? Branchement aux apps nécessaire ?

@xav-car
Copy link
Contributor

xav-car commented May 13, 2024

A vérifier que les modifications apporté fonctionne correctement

Une reco de comment tester ? Branchement aux apps nécessaire ?

Je me suis dit que la documentation de PixUI pour le npm pack etc... suffisait 😅

@yannbertrand
Copy link
Member

A vérifier que les modifications apporté fonctionne correctement

Une reco de comment tester ? Branchement aux apps nécessaire ?

Je me suis dit que la documentation de PixUI pour le npm pack etc... suffisait 😅

Fonctionnellement je veux dire je vois pas trop quoi tester 😅

@xav-car
Copy link
Contributor

xav-car commented May 13, 2024

A vérifier que les modifications apporté fonctionne correctement

Une reco de comment tester ? Branchement aux apps nécessaire ?

Je me suis dit que la documentation de PixUI pour le npm pack etc... suffisait 😅

Fonctionnellement je veux dire je vois pas trop quoi tester 😅

PixPagination => changement de page / size dans l'url en direct est ce que ça pète ou pas .
Vérifier que le PixSelect / MultiSelect sont toujours ok

Je crois que c'est à peu près tout.

@lionelB
Copy link
Contributor

lionelB commented May 14, 2024

fonc OK

@aurelie-crouillebois
Copy link
Contributor

Dans le filterable and searchable select, j'ai ça qui s'affiche :
Capture d’écran 2024-05-23 à 09 57 24
Au lieu de ça avant :
Capture d’écran 2024-05-23 à 09 58 25

@aurelie-crouillebois
Copy link
Contributor

C'est probablement lié au 1er problème, mais la taille du select ne s'adapte pas au contenu le plus long comme c'était le cas avant.

@xav-car xav-car force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch 5 times, most recently from 4ba7ec8 to 00204f8 Compare May 23, 2024 13:43
@xav-car
Copy link
Contributor

xav-car commented May 23, 2024

Dans le filterable and searchable select, j'ai ça qui s'affiche : Capture d’écran 2024-05-23 à 09 57 24 Au lieu de ça avant : Capture d’écran 2024-05-23 à 09 58 25

Bien vu . j'étais passé à côté de celui là. ✅

@xav-car xav-car force-pushed the renovate/dossier-racine-ember-template-lint-6.x branch from 00204f8 to 9dc0fa2 Compare May 27, 2024 14:59
@pix-service-auto-merge pix-service-auto-merge merged commit 8e20314 into dev May 27, 2024
8 of 9 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the renovate/dossier-racine-ember-template-lint-6.x branch May 27, 2024 15:08
pix-service-auto-merge pushed a commit that referenced this pull request May 27, 2024
## [46.4.3](v46.4.2...v46.4.3) (2024-05-27)

### ⬆️ Montée de version

- [#593](#593) Update dependency ember-template-lint to v6 (dossier racine) (PIX-12410)
@pix-service-auto-merge
Copy link
Contributor

🎉 This PR is included in version 46.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team Toutes les équipes de dev dependencies Pull requests that update a dependency file Func Review OK released 🚀 Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants