[TECH] Améliorer la clareté d'un bout de code manipulant window.location (PIX-12266) #8725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Le code suivant n’est pas très clair :
🤖 Proposition
Mentionner explicitement
window.location
comme cela a été fait dans https://github.com/1024pix/pix/blob/dev/admin/app/routes/authentication/login-oidc.js#L98-L101 :🌈 Remarques
cf. https://developer.mozilla.org/en-US/docs/Web/API/Window/location
💯 Pour tester
Vérifier qu'une connexion par SSO OIDC fonctionne.