[TECH] Regrouper la gestion des centres (PIX-12462). #8892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
mcampourcy
force-pushed
the
pix-12462-group-centers-management
branch
6 times, most recently
from
923911f
to
c133f70
Compare
AndreiaPena
changed the title
mcampourcy
force-pushed
the
pix-12462-group-centers-management
branch
from
c133f70
to
21ba9a2
Compare
mcampourcy
force-pushed
the
pix-12462-group-centers-management
branch
2 times, most recently
from
92e6535
to
7893745
Compare
mcampourcy
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
mcampourcy
force-pushed
the
pix-12462-group-centers-management
branch
2 times, most recently
from
67bbf96
to
ac779d2
Compare
aceol
reviewed
May 21, 2024
aceol
approved these changes
May 21, 2024
| createdAt: 'certification-centers.createdAt', | ||
| updatedAt: 'certification-centers.updatedAt', | ||
| isV3Pilot: 'certification-centers.isV3Pilot', | ||
| isComplementaryAlonePilot: knex.raw( |
There was a problem hiding this comment.
On peut en avoir plusieurs? je ne comprends pas pourquoi le count
...ts/integration/infrastructure/repositories/certification-center-for-admin-repository_test.js
Outdated
Show resolved
Hide resolved
api/lib/infrastructure/repositories/certification-point-of-contact-repository.js
Outdated
Show resolved
Hide resolved
| * @param {Array} centerList - List of certification centers. | ||
| * @returns {Promise<Array>} - List of allowed center accesses. | ||
| */ | ||
| const getAllowedCenterAccesses = async function (centerList) { |
There was a problem hiding this comment.
On ne se sert que des ids, peut etre qu'on ne devrait prendre en parametre que cela
There was a problem hiding this comment.
Faire un centerIdList ? Le problème c'est qu'on se sert des autres informations + bas, dans le toDomain
Steph0
approved these changes
May 22, 2024
api/lib/infrastructure/repositories/certification-point-of-contact-repository.js
Outdated
Show resolved
Hide resolved
Steph0
approved these changes
May 22, 2024
mcampourcy
force-pushed
the
pix-12462-group-centers-management
branch
2 times, most recently
from
2d8e25e
to
ff55052
Compare
mcampourcy
force-pushed
the
pix-12462-group-centers-management
branch
from
ff55052
to
e72d286
Compare
| @@ -110,7 +110,7 @@ describe('Integration | Repository | CertificationPointOfContact', function () { | |||
| type: certificationCenter.type, | |||
| isV3Pilot: certificationCenter.isV3Pilot, | |||
| habilitations: [], | |||
| isComplementaryAlonePilot: false, | |||
| // isComplementaryAlonePilot: false, | |||
There was a problem hiding this comment.
On dé-commente ou on supprime ? :)
Steph0
force-pushed
the
pix-12462-group-centers-management
branch
from
e72d286
to
ac5bf5b
Compare
mcampourcy
force-pushed
the
pix-12462-group-centers-management
branch
from
ac5bf5b
to
3e6b408
Compare
|
J'ai cassé la RA, vu avec @mcampourcy je ferme et j'ouvre une autre PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
On répète à de nombreux endroits les mêmes instructions dans le cadre de la Séparation Pix / Pix+, notamment de récupérer pour un centre donné ses features (CAN_REGISTER_FOR_A_COMPLEMENTARY_CERTIFICATION_ALONE)
On constate déjà à ce jour
Un objet Center.js dans api/src/certification/enrolment/domain/models/Center.js qui représente un centre de certif de manière générique
Un objet CertificationCenterForAdmin dans api/lib/domain/models/CertificationCenterForAdmin.js qui est un aggregat entre les informations d’un centre + le DPO officer
Un objet AllowedCertificationCenterAccess dans api/lib/domain/read-models/AllowedCertificationCenterAccess.js qui est un aggregat entre un centre, des tags et des informations supplémentaires lié au SCO
On voudrait mettre en cohérence ce code pour éviter de refaire un nombre identique de fois les mêmes opérations qui sont faites dans les repositories.
🤖 Proposition
🌈 Remarques
💯 Pour tester