Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Migrer la route POST /api/oidc/token vers src/identity-access-management (PIX-12524) #8926

Merged

Conversation

igorissen
Copy link
Contributor

@igorissen igorissen commented May 15, 2024

🦄 Problème

La route POST /api/oidc/token est encore dans le dossier lib.

🤖 Proposition

Faire la migration vers son bounded context identity-access-management.

🌈 Remarques

Suppression de code mort. Après l'ajout de la librairie node-openid-client, nous n'avons plus besoin que les applications fournissent une redirect_uri à l'api.

La PR suivante doit être validée avant :

💯 Pour tester

  • Faire le test de connexion, ainsi que la création d'un nouveau compte sur tous les fournisseurs d'identité.
  • Se reconnecter avec le même compte pour chacun des fournisseurs d'identité

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@igorissen igorissen changed the title [TECH] Migrer la route POST /api/oidc/token vers src/identity-access-management (PIX-xxx) [TECH] Migrer la route POST /api/oidc/token vers src/identity-access-management (PIX-12524) May 16, 2024
@igorissen igorissen force-pushed the bc-move-oidc-authenticate-user-route-to-iam branch 3 times, most recently from 1621c9f to 1a87a7e Compare May 21, 2024 13:07
Copy link
Contributor

@er-lim er-lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test en local sur firefox ✅

Copy link
Contributor

@EmmanuelleBonnemay EmmanuelleBonnemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lu et testé avec succès sur Firefox

igorissen and others added 9 commits May 22, 2024 14:11
to identity-access-management bounded context
to identity-access-management bounded context
code from controller to usecase
to identity-access-management bounded context
to remove authentication and user-account directories, and add identity-access-management directory
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
@pix-service-auto-merge pix-service-auto-merge force-pushed the bc-move-oidc-authenticate-user-route-to-iam branch from 1a87a7e to c3f4709 Compare May 22, 2024 14:11
@pix-service-auto-merge pix-service-auto-merge merged commit a067ec2 into dev May 22, 2024
5 of 7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the bc-move-oidc-authenticate-user-route-to-iam branch May 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants