-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit vulnerabilities check #10038
Conversation
Adding @fabiocav as well. We added this to break the build on checking packages. We should discuss how Component Governance can assist here. |
Will this create a temporary gap? This check has already helped us identify issues prior to releases, and if we're removing, we want to make sure we don't end up with CVE impacted transitive dependencies as those will be flagged by other tools post-deployment/release. |
@FinVamp1, component governance is the official way for Microsoft repos to manage security audits when using open-source software. It will cover transitive dependencies, set due dates, allow extensions and dismissing of not applicable incidents. |
<PackageReference Include="System.Reactive.Linq" Version="5.0.0" /> | ||
<PackageReference Include="System.Reactive.Core" Version="5.0.0" /> | ||
<PackageReference Include="System.Runtime.Loader" Version="4.3.0" /> | ||
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a few new refs here -- was that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component governance flags these as vulnerable. Although it is not an issue at runtime since the WebHost has thse versions. Just adding them here to satisfy CG.
Will be replaced with 1ES work |
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
This is an alternative to #10037
Removes the explicit vulnerabilities check. Now that we use the .NET8 SDK this is no longer needed as there is a built in nuget audit as part of the restore phase.
IMPORTANT: There is a behavior difference (which is the goal here), we only fail on moderate and above now. In this case we have CVE GHSA-x674-v45j-fwxw which does not affect us, yet our current approach blocks the build. I could work on a way to integrate suppressions into the existing vuln check script, but when moving to 1ES we will be covered by component governance.