-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deesharma/connectedclusternewversion #29148
Open
deeksha345
wants to merge
11
commits into
Azure:main
Choose a base branch
from
deeksha345:deesharma/connectedclusternewversion
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Deesharma/connectedclusternewversion #29148
deeksha345
wants to merge
11
commits into
Azure:main
from
deeksha345:deesharma/connectedclusternewversion
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
connectedClusters.json | 2024-06-01-preview(4ef0e51) | 2024-01-01(main) |
connectedClusters.json | 2024-06-01-preview(4ef0e51) | 2024-02-01-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 5 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-preview-2024-06-01 | package-preview-2024-06-01(4ef0e51) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L867 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L871 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L883 |
||
Missing identifier id in array item property Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L919 |
||
Missing identifier id in array item property Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L926 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L31 |
SubscriptionsAndResourceGroupCasing |
The path segment resourcegroups should be resourceGroups. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L31 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L79 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L85 |
PatchIdentityProperty |
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L129 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L142 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L186 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L198 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L228 |
ResourceNameRestriction |
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L247 |
SubscriptionsAndResourceGroupCasing |
The path segment resourcegroups should be resourceGroups. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L247 |
SubscriptionsAndResourceGroupCasing |
The path segment resourcegroups should be resourceGroups. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L308 |
OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Kubernetes/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L406 |
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L407 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L491 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L516 |
SystemDataDefinitionsCommonTypes |
System data references must utilize common types. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L522 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L592 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L703 |
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L34 |
|
Use the latest version v5 of types.json. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L55 |
|
Use the latest version v5 of types.json. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L58 |
|
Use the latest version v5 of types.json. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L61 |
|
Use the latest version v5 of types.json. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L92 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L103 |
|
Use the latest version v5 of types.json. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L118 |
|
Use the latest version v5 of types.json. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L121 |
|
Use the latest version v5 of types.json. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L124 |
|
Use the latest version v5 of types.json. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L149 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L156 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
new-api-version
resource-manager
RPaaS
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
May 17, 2024
This was referenced May 17, 2024
AzureRestAPISpecReview
added
the
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
label
May 20, 2024
….com/deeksha345/azure-rest-api-specs into deesharma/connectedclusternewversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
BreakingChange-Go-Sdk
BreakingChange-Python-Sdk
new-api-version
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
RPaaS
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.